Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of UCTS trigger in interleaved pedestals events #403

Merged

Conversation

FrancaCassol
Copy link
Collaborator

Remove the check of UCTS trigger in interleaved pedestal events, because often wrong.

@DirkHoffmann
Copy link

Remove the check of UCTS trigger

Is this because the TTYPE is wrong, or is the TIB information correct in these casees?

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #403 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   41.46%   41.46%           
=======================================
  Files          76       76           
  Lines        6143     6143           
=======================================
  Hits         2547     2547           
  Misses       3596     3596           
Impacted Files Coverage Δ
lstchain/calib/camera/calibration_calculator.py 27.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14509d...650ece2. Read the comment docs.

@FrancaCassol
Copy link
Collaborator Author

Remove the check of UCTS trigger

Is this because the TTYPE is wrong, or is the TIB information correct in these casees?

For the cases I could see the TIB information is either correct or absent.
But, we will have a more global view of that after the next data processing.

@rlopezcoto rlopezcoto merged commit 6423f21 into cta-observatory:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants