DL1 scaling

[vuillaut]

resolves #433

[codecov]

Codecov Report

Merging #435 into master will increase coverage by 0.17%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   41.56%   41.74%   +0.17%     
==========================================
  Files          76       77       +1     
  Lines        6192     6212      +20     
==========================================
+ Hits         2574     2593      +19     
- Misses       3618     3619       +1     

Impacted Files	Coverage Δ
lstchain/reco/r0_to_dl1.py	64.48% <80.00%> (+0.27%)	⬆️
lstchain/reco/tests/test_r0_to_dl1.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c294c...0699d0c. Read the comment docs.

[moralejo]

Thanks!
Just for clarity, I would rename mc_dl1_scaling_factor to "mc_dl1a_scaling_factor" or "mc_light_scaling_factor"

[maxnoe]

Just for clarity, I would rename mc_dl1_scaling_factor to "mc_dl1a_scaling_factor" or "mc_light_scaling_factor"

It's applied only to dl1.image, so why not mc_image_scaling?

[vuillaut]

image seemed more appropriate, I made the change.

[vuillaut]

Note: with ctapipe v0.8 this correction can be done with the relative_factor in the DL1 Calibration Container.