Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write array info a la ctapipe v0.8 #466

Merged

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Jul 9, 2020

Double the info (small overhead) for now to not change the data format.
This is temporary for lstchain v0.6

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@vuillaut vuillaut closed this Jul 9, 2020
@vuillaut vuillaut reopened this Jul 9, 2020
@vuillaut vuillaut changed the base branch from master to lstchain_ctapipe0.8 July 9, 2020 10:02
@vuillaut vuillaut requested a review from moralejo July 9, 2020 10:02
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #466 into lstchain_ctapipe0.8 will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           lstchain_ctapipe0.8     #466      +/-   ##
=======================================================
+ Coverage                41.63%   41.71%   +0.07%     
=======================================================
  Files                       76       76              
  Lines                     6199     6207       +8     
=======================================================
+ Hits                      2581     2589       +8     
  Misses                    3618     3618              
Impacted Files Coverage Δ
lstchain/io/io.py 82.33% <100.00%> (+0.38%) ⬆️
lstchain/reco/r0_to_dl1.py 65.08% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e50a3e...5c17bde. Read the comment docs.

@vuillaut
Copy link
Member Author

vuillaut commented Jul 9, 2020

image

@vuillaut vuillaut merged commit dbc81be into cta-observatory:lstchain_ctapipe0.8 Jul 9, 2020
@vuillaut vuillaut deleted the write_array_nifo branch July 9, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants