Removed the duplicated masks for DL1 parameters & images #478
Conversation
…bles, since they have one-to-one corresponding rows. Besides, code did not work because images table now lacks event_id
Codecov Report
@@ Coverage Diff @@
## lstchain_ctapipe0.8 #478 +/- ##
=======================================================
+ Coverage 42.03% 42.06% +0.03%
=======================================================
Files 76 76
Lines 6290 6285 -5
=======================================================
Hits 2644 2644
+ Misses 3646 3641 -5
Continue to review full report at Codecov.
|
That should not be, everything needs to be identifiable |
calculation of telescope efficiency with muon rings.
I thought it was by design, since the rows in the two tables correspond one to one, so the event_id in both would be redundant. As long as things work properly, of course! If we want absolute safety we could put back that event_id in ctapipe... |
This is clearly a bug, since the tool has the option to only write the image table But wait: you are talking about the lstchain dl1 processing, not the ctapipe tool? Then this has nothing to do with ctapipe, it needs to be fixed here! |
This happened as a result of a change in ctapipe, but indeed it makes no sense to change anything in ctapipe (or even in lstchain) since we will move as soon as possible to the new DL1. So no need to do anything about this. |
The containers don't duplicate this information anymore, this is right. For writing it out, we use the |
Removed the duplicated masks for the DL1 parameters and DL1 images tables,
since they have one-to-one corresponding rows. Besides, code did not work
because images table now lacks event_id