Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gps_time #493

Merged

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Jul 27, 2020

gps time is not used anywhere and is now written as nan value in dl1, causing errors down the line.

Same error can get caused by mc_core_distance filled by nan

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #493 into lstchain_ctapipe0.8 will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           lstchain_ctapipe0.8     #493      +/-   ##
=======================================================
- Coverage                41.61%   41.59%   -0.02%     
=======================================================
  Files                       77       77              
  Lines                     6430     6428       -2     
=======================================================
- Hits                      2676     2674       -2     
  Misses                    3754     3754              
Impacted Files Coverage Δ
lstchain/reco/r0_to_dl1.py 64.96% <ø> (-0.12%) ⬇️
lstchain/io/lstcontainers.py 87.81% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545e427...3405ce7. Read the comment docs.

@tysaito2008
Copy link

thank you for removing it. It was just confusing.

Copy link
Contributor

@andres-baquero andres-baquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes running lstchain_dl1_to_dl2.py and it is running well.

@vuillaut
Copy link
Member Author

I have tested the changes running lstchain_dl1_to_dl2.py and it is running well.

Thank you for the test and review

@vuillaut vuillaut merged commit 9b6fe2a into cta-observatory:lstchain_ctapipe0.8 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants