Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ucts fix to account for wrongly tagged pedestal events due to skipping events #497

Merged
merged 19 commits into from
Sep 14, 2020

Commits on Jul 29, 2020

  1. Configuration menu
    Copy the full SHA
    47d1ce3 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Make sure that possible jumps in event_id are properly considered whe…

    …n correcting the UCTS info
    moralejo committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    6dd3b2b View commit details
    Browse the repository at this point in the history
  2. Revert "Make sure that possible jumps in event_id are properly consid…

    …ered when correcting the UCTS info"
    
    This reverts commit 6dd3b2b.
    moralejo committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    01e9e58 View commit details
    Browse the repository at this point in the history
  3. Revert "Firs try at correcting UCTS time stamps"

    This reverts commit 47d1ce3.
    moralejo committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    02492d7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8362d79 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3796c65 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Make that all events are written out to the DL1 output file, no matter

    whether the image parametrization was successful or not
    moralejo committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    b26964f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    016b3b1 View commit details
    Browse the repository at this point in the history
  3. Removed blank line

    moralejo committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    3fd7a61 View commit details
    Browse the repository at this point in the history
  4. Put default nans in width and length in meters, otherwise the program

    complains later when doing e.g. atan(width/foclength)
    moralejo committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    80d2f3a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    88f9978 View commit details
    Browse the repository at this point in the history
  6. Comparison between parameters of a DL1 file produced directly from si…

    …mtel,
    
    with those in one produced from the very same DL1 (redoing the cleaning and
    parametrization) is now done only for events in which intensity is not nan,
    since the former file may now contain events in which the Hillas
    parametrization was unsuccessful
    moralejo committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    23c0540 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d71e0a5 View commit details
    Browse the repository at this point in the history
  8. I give up, writing out the events which do not survive the image clea…

    …ning
    
    and parametrization to the DL1 file is too difficult because the
    (deprecated) DL1ParametersContainer is a mess. Basically, a reset() leaves
    it in a state (initialized with None's, no units) which is incompatible
    with writing it later. And I do not think it is worth to fill manually all
    the values for empty events, given the container is deprecated.
    moralejo committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    c3a08ee View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2020

  1. Found a way to write out all events, including those not surviving cl…

    …eaning,
    
    and still keep copnsistency between r0_to_dl1 and dl1ab
    moralejo committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    31e6499 View commit details
    Browse the repository at this point in the history
  2. Simplified code

    moralejo committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    ff69ec4 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2020

  1. Fixed bug - the previous version would assign the wrong trigger type …

    …in case
    
    of more than one UCTS jump. Also: set -1 as ucts_trigger_type of events with
    no valid UCTS info.
    moralejo committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    5f1aa04 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Configuration menu
    Copy the full SHA
    676795b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fedbd4 View commit details
    Browse the repository at this point in the history