Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook rf-performance.ipynb #500

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Update notebook rf-performance.ipynb #500

merged 2 commits into from
Sep 14, 2020

Conversation

lfoffano
Copy link
Contributor

Several functions were outdated and have been updated.
Improved readibility and conformity to the new lstchain.

Several functions were outdated and have been updated. 
Improved readibility and conformity to the new lstchain.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #500 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   41.60%   41.58%   -0.02%     
==========================================
  Files          77       77              
  Lines        6430     6430              
==========================================
- Hits         2675     2674       -1     
- Misses       3755     3756       +1     
Impacted Files Coverage Δ
lstchain/version.py 43.93% <0.00%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e70a8...ed15fd1. Read the comment docs.

@review-notebook-app
Copy link

review-notebook-app bot commented Aug 28, 2020

View / edit / reply to this conversation on ReviewNB

rlopezcoto commented on 2020-08-28T13:23:32Z
----------------------------------------------------------------

cta-lstchainand -> cta-lstchain and


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 28, 2020

View / edit / reply to this conversation on ReviewNB

rlopezcoto commented on 2020-08-28T13:23:33Z
----------------------------------------------------------------

Make it a markdown cell


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 28, 2020

View / edit / reply to this conversation on ReviewNB

rlopezcoto commented on 2020-08-28T13:23:34Z
----------------------------------------------------------------

Same as above, markdown cell


lfoffano commented on 2020-09-07T06:45:24Z
----------------------------------------------------------------

sorry, I think I have already made them markdown cell. Is there anything else I can change?

Copy link
Contributor Author

lfoffano commented Sep 7, 2020

sorry, I think I have already made them markdown cell. Is there anything else I can change?


View entire conversation on ReviewNB

@rlopezcoto rlopezcoto merged commit 7b3c127 into cta-observatory:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants