Correct the gain selection mask #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlopezcoto
reviewed
Sep 15, 2020
There was a problem hiding this comment.
Thanks @FrancaCassol, could you add a comment in the code on why for the meantime we are leaving no_gain_selection[1] = 1 ?
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 41.50% 41.48% -0.02%
==========================================
Files 77 77
Lines 6498 6501 +3
==========================================
Hits 2697 2697
- Misses 3801 3804 +3
Continue to review full report at Codecov.
|
maxnoe
reviewed
Sep 15, 2020
| @@ -189,7 +189,7 @@ def _calibrate_dl1(self, event, telid): | |||
| # TBD: - perform calibration of the R1 waveform (not DL1) | |||
| # - gain selection before charge integration | |||
|
|
|||
|
|
|||
| # In case of no gain selection the selected gain channels are [0,0,..][1,1,..] | |||
There was a problem hiding this comment.
This is not "no gain selection", right? This is "always choose high-gain"?
There was a problem hiding this comment.
no, this is no gain selection, why do you say that?
rlopezcoto
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the present gain mask that would bring to wrong results if the charge integration correction is activated (which is not the case now)
Remove an obsolete card in the configuration file