-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default calibration scaling factor tp account for different integration windows and the effect of sampling inhomogeneities #516
Conversation
…fferent integration window among cosmics and laser events [HG,LG]=[1.088,1.004] (from slide 12 of https://indico.cta-observatory.org/event/2853/contributions/24597/attachments/17750/23853/ChargeRecoYukiho20200629.pdf) and the estimated effect on the gain due to the time sampling inhomogeneity [HG,LG]=[1.05,1.10]. - Update the excess noise factor to the most recent estimated value
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 41.48% 41.48%
=======================================
Files 77 77
Lines 6501 6501
=======================================
Hits 2697 2697
Misses 3804 3804
Continue to review full report at Codecov.
|
@FrancaCassol @rlopezcoto I think we rather want We want to integrate 8 samples in shower images to let in less noise, and then we just want to convert it (in average) to what we would get by integrating (those same pulses) in 12 samples. So I think those factors are a bit underestimated. |
Hi @moralejo, yes, I agree, for that in my comment I added the sentence "It will remain a small underestimation of the light with respect to MC due to the 12 ns window, taken here as reference". |
Hi @FrancaCassol, I did not refer to the remaining pulse beyond 12 samples, but to the fact that the ratios we are using (of 12 vs. 8) are not obtained for the same pulse shapes (one is calib, the other cosmic) |
@moralejo, I think this was the idea, they better correspond to what we have in the data ... |
@moralejo, actually thinking it again, we even do not have the 12 ns problem: the coefficient were calculated as the ratio: extract_FF(12 ns)/extract_cosmic(8 ns) The idea behind is :
So the overall correction factor for the coefficients dc_to_pe is : which is what proposed... |
Dear @FrancaCassol and @moralejo, Thank you very much for this important implementation. My understanding is consistent with Franca's comment. The correction factor extract_FF(12 ns)/extract_cosmic(8 ns) would be reasonable with the current status. Another point: The effect of DRS4 sampling inhomogeneity correction on conversion factors is ~5% for both HG and LG. So I think the correction factors for this effect would be [HG,LG]=[1.05,1.05] (not [1.05,1.10]). |
Hi @FrancaCassol the point is that |
Hi @rlopezcoto , indeed for LG I had more a value of 1.14 (instead of 1.10), but we decided to be more optimistic ;-) . Could you please try again with 1.14? I am in any case recalculating everything with higher statistics. Those values were not meant to be totally precise, the idea was to become closer to the reality for the just coming release |
Dear @yukihok,
These values are estimated taking into account all the systematics (proportional to the charge) and LG is globally more affected. I am going to explain the method next Monday at the LST analysis meeting. As said above, these values must be considered as provisory |
Dear @FrancaCassol, I see, thank you for the explanation. Then I will wait for the next call :) |
Not clear to me why you would convert the 8-sample integrated charge in cosmics pulses to 12-sample in FF pulses. I think the idea of the integration correction is to obtain the # of adc counts we would get if we integrated the cosmics pulses in 12 samples instead if 8. |
For the record, when applying the new factor calculated in #530 , for HG and LG, the difference between |
Ok, I now think you are right @FrancaCassol, below I just try to put my thoughts together: Let's assume for a moment the NSB noise is very low, and we can integrate as many as 20 samples. NOTE!: Uppercase Q: cosmic charges. Lowercase q: FF charges. We do the FF method on flatfield events, and (assuming the parameters of the method reflect reality) obtain npe as number of photoelectrons Then we calculate gain = npe/q_20 [units: pe/adc_count] where q_20 is the average 20-sample integrated charge for FF events. This conversion factor will be ok for "whatever" t-distribution of the incoming photons, as long as all of them (and their tails) are within the 20-sample integration window. Now we want to integrate cosmics in a smaller window, say 8 samples. But, in order to be able to use the calculated "gain", we want to extrapolate the result to the total number of adc counts we would obtain (in average, in cosmics) if we had integrated 20. So we take the average ratio <Q_20/Q_8> for cosmics pulses, and hence the new gain is corrected_gain = gain*<Q_20/Q_8> and we obtain the number of p.e. in cosmic pulses as corrected_gain*Q_8 Now, in reality, we are not calculating the FF with 20 samples, but according to Yukiho's estimates this just underestimates the number of p.e by 1.0-1.25% This slightly underestimated number is, again, npe. I will ignore the small underestimation. Then, the gain, with the same definition as above (extrapolating to 20 samples), would be gain = npe / [q_12*<q_20/q_12>] Now we want to use 8 samples for cosmics: corrected_gain = gain*<Q_20/Q_8>, same as before, i.e. npe / [q_12*<q_20/q_12>)] * <Q_20/Q_8> = npe/q_12 * <q_12/q_20> * <Q_20/Q_8> = npe/q_12 * <q_12/q_20> / <Q_8/Q_20> I think is what you Franca and Yukiho proposed, and seems correct to me. Then Rubén checked in the data empirically the difference between integrating 8 samples (and using the above corrected gain factor) and integrating 12 samples (with no pulse integration correction). So what he did to obtain the number of pe in cosmics is while we should do npe/q_12 * <q_12/q_20> / <Q_12/Q_20> * Q_12 NOTE: original entry was edited from here, following @yukihok 's correction!
<q_12/q_20> / <Q_12/Q_20> = 1./1.056 =0.947 for the high gain From @yukihok study, <q_12 / q_20> = 0.911 which would mean: <Q_12 / Q_20> = 0.962 for the HG. So this seems pretty consistent, and the ~1% differences might be just due to the different calculations: Ruben's is obtained as an average of the ratio for many events (brightest pixel) while Yukiho's is obtained first averaging the pulse shapes, then integrating. Many issues may be at play here: how the pulses are superimposed, how they are selected (they are bright pulses), whether the chosen pixel(s) are representative... It is not obvious to what precision the two values should agree. I tend to think that for the purpose of finding the best conversion factor the "event-wise-ratio" method id more straightforward. It tests the effect for the actual integration process we use, not for an average pulse. Anyway, the difference is pretty small so we can ignore it for the time being - at least until we calibrate the MC regularly in exactly the same way as the real data (with simulated FF runs) |
Thank you very much @moralejo for getting things straight. Concerning the comparison between Ruben’s analysis and mine, please let me try to clarify below and please correct me if I’m wrong. (Here, I will neglect correction factor for DRS4 correction just for simplicity.) As far as I can see, what @rlopezcoto calculated is ratio between the following two npe values estimated in different ways. npe_num = gain * Q_8 * correction (Here, gain = npe/q_12 and correction = q_12/Q_8 as proposed initially) So the calculated ratio should correspond to R = npe_num/npe_den = q_12/Q_12. (This seems an inverse of @moralejo’s explanation…) If I calculate the same R using average pulse shapes, the result is R = q_12/Q_12 ~ [0.96 (HG), ~0.98 (LG)]. Any feedback is very welcome. Let me put some relevant charge values (normalized by 20 ns integration) from my pulse shape analysis just for reference. (The two values mean HG and LG respectively) |
HI @yukihok, thanks for your input. You are right, I made a mistake and inverted the ratio obtained by @rlopezcoto. I edited my entry to avoid confusion. @rlopezcoto I think this means that, contrary to what we had discussed, we do not have to incorporate any correction factor relative to what @FrancaCassol had calculated for use with 8 samples. The factor 1.056 you applied to the 8-sample integration here: https://user-images.githubusercontent.com/17042312/94912854-8f4ae880-04a8-11eb-9e00-ea76b4ab9663.png should actually be applied (inverted) to the 12-sample integration. |
thanks @moralejo, @yukihok and @FrancaCassol for the explanations. It seems that the misleading thing to me was not to consider that the |
Modify the global calibration scaling factor including:
1. The factor due to the different integration window in cosmics (8 ns) and laser events (12 ns). We use the values estimated on data by Yukiho (see slide 12) : [HG,LG]=[1.088,1.004]
2. The average estimated effect on the gain due to the DRS4 time sampling inhomogeneities and laser variation: [HG,LG]=[1.05,1.10]
Update the excess noise factor to the most recent estimated value (Fˆ2=1.222)
It will remain a small underestimation of the light with respect to MC due to the 12 ns window, taken here as reference