-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read dl2 and sim info into pyirf internal format #521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 41.48% 41.65% +0.17%
==========================================
Files 77 77
Lines 6501 6520 +19
==========================================
+ Hits 2697 2716 +19
Misses 3804 3804
Continue to review full report at Codecov.
|
Maybe working on a pyirf branch until everything is ready might be a good idea instead of merging pieces into the master? |
I agree with @maxnoe, specially now that we are finalizing the tests on the data before releasing v0.6.1, it would be nice not to include in the master any non-necessary changes not to break any compatibilities and have reproducible results |
For me tests are not passing, it complains about missing pyirf. |
Yes, the setup file also has to be updated, and as @maxnoe suggested, we will work on a separate branch to work on our scripts, until both lstchain and pyirf are ready for the DL3 scripts. |
Ok, please revert these changes. Amazingly I cannot even run the R0 to DL1 step - though it should not at all be related to IRFs, I guess |
|
@moralejo I guess that you need to update the environment with: does that work? |
Yes, thanks! I thought pip install would do it... |
I will add a unit test