Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ctapipe to 0.12.0, gammapy 0.19, pyirf 0.6 #802

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Dec 3, 2021

Needs a new release of ctapipe_io_lst, until that is done, this is in draft mode.

It seems changes are again not large, so me might want to update already.

@rlopezcoto
Copy link
Contributor

ctapipe_io_lst v0.12 was already released and included in lstchain, anything else missing?

@rlopezcoto
Copy link
Contributor

sorry, I just saw the pending PR cta-observatory/ctapipe_io_lst#128, that would need to be merged and a new release of ctapipe_io_lst issued before moving on

@maxnoe
Copy link
Member Author

maxnoe commented Jan 21, 2022

This just updates and fixes tests along with removing subarray related IO functions that are now served using Subarray.{from,to}_hdf

@maxnoe maxnoe marked this pull request as ready for review January 21, 2022 17:57
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #802 (865955a) into master (70bbb7c) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   83.71%   83.84%   +0.12%     
==========================================
  Files          76       76              
  Lines        5992     5916      -76     
==========================================
- Hits         5016     4960      -56     
+ Misses        976      956      -20     
Impacted Files Coverage Δ
lstchain/calib/camera/calibration_calculator.py 89.65% <ø> (ø)
lstchain/calib/camera/flatfield.py 96.22% <ø> (ø)
lstchain/calib/camera/pedestals.py 95.60% <ø> (ø)
lstchain/io/tests/test_io.py 100.00% <ø> (ø)
lstchain/tools/lstchain_create_dl3_index_files.py 77.77% <ø> (ø)
lstchain/tools/lstchain_create_irf_files.py 90.16% <ø> (ø)
lstchain/visualization/plot_calib.py 100.00% <ø> (ø)
lstchain/io/io.py 73.00% <100.00%> (+0.46%) ⬆️
lstchain/reco/r0_to_dl1.py 93.71% <100.00%> (ø)
lstchain/scripts/tests/test_lstchain_scripts.py 99.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70bbb7c...865955a. Read the comment docs.

@maxnoe maxnoe linked an issue Jan 24, 2022 that may be closed by this pull request
@maxnoe maxnoe changed the title Update ctapipe to 0.12.0 Update ctapipe to 0.12.0, gammapy 0.19, pyirf 0.6 Jan 24, 2022
Copy link
Contributor

@rlopezcoto rlopezcoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks fine to me in general, I left a couple of comments and let's see if @FrancaCassol can have a look to the changes affecting the calibration code

lstchain/io/io.py Show resolved Hide resolved
lstchain/tools/lstchain_fit_intensity_scan.py Show resolved Hide resolved
lstchain/visualization/plot_calib.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
environment.yml Show resolved Hide resolved
FrancaCassol
FrancaCassol previously approved these changes Jan 24, 2022
rlopezcoto
rlopezcoto previously approved these changes Jan 24, 2022
@rlopezcoto
Copy link
Contributor

there are still some conflicts to be solved, otherwise the PR looks good already

@maxnoe
Copy link
Member Author

maxnoe commented Jan 27, 2022

Ah sorry, I didn't catch that there were conflicts again.

@maxnoe maxnoe merged commit d3e5503 into master Jan 27, 2022
@maxnoe maxnoe deleted the ctapipe0.12.0 branch January 27, 2022 16:58
maxnoe added a commit that referenced this pull request Jan 27, 2022
Update ctapipe to 0.12.0, gammapy 0.19, pyirf 0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update core dependencies
4 participants