-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ctapipe to 0.12.0, gammapy 0.19, pyirf 0.6 #802
Conversation
|
sorry, I just saw the pending PR cta-observatory/ctapipe_io_lst#128, that would need to be merged and a new release of |
b8dc98f
to
7701e66
Compare
This just updates and fixes tests along with removing subarray related IO functions that are now served using |
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 83.71% 83.84% +0.12%
==========================================
Files 76 76
Lines 5992 5916 -76
==========================================
- Hits 5016 4960 -56
+ Misses 976 956 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks fine to me in general, I left a couple of comments and let's see if @FrancaCassol can have a look to the changes affecting the calibration code
e6f7a56
to
ebd6caf
Compare
there are still some conflicts to be solved, otherwise the PR looks good already |
Ah sorry, I didn't catch that there were conflicts again. |
Update ctapipe to 0.12.0, gammapy 0.19, pyirf 0.6
Needs a new release of ctapipe_io_lst, until that is done, this is in draft mode.
It seems changes are again not large, so me might want to update already.