Correct number of ucts jumps #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure not to double-count the number of UCTS jumps occurring in a run. Previous version counted each jump again in every subsequent subrun.
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 72 72
Lines 5564 5564
=======================================
Hits 4729 4729
Misses 835 835 Continue to review full report at Codecov.
|
maxnoe
reviewed
Jan 3, 2022
maxnoe
previously approved these changes
Jan 3, 2022
nonzero does not work with pandas dataframe (would need to convert with .to_numpy, but np.where does not have that problem)
maxnoe
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure not to double-count the number of UCTS jumps occurring in a run. Previous version counted each jump again in every subsequent subrun.