Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pedestal and flatfield calculator not taking extractor configuration, fixes #890 #891

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jan 27, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #891 (1768264) into master (70bbb7c) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   83.71%   83.86%   +0.14%     
==========================================
  Files          76       77       +1     
  Lines        5992     6029      +37     
==========================================
+ Hits         5016     5056      +40     
+ Misses        976      973       -3     
Impacted Files Coverage Δ
lstchain/calib/camera/flatfield.py 96.29% <100.00%> (+0.06%) ⬆️
lstchain/calib/camera/pedestals.py 95.69% <100.00%> (+0.09%) ⬆️
lstchain/calib/camera/tests/test_calculator.py 100.00% <100.00%> (ø)
lstchain/conftest.py 96.51% <100.00%> (+0.17%) ⬆️
lstchain/calib/camera/calibration_calculator.py 93.10% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70bbb7c...1768264. Read the comment docs.

@maxnoe maxnoe merged commit 14916d4 into master Jan 27, 2022
@maxnoe maxnoe deleted the calibrator_config branch January 27, 2022 16:40
@maxnoe
Copy link
Member Author

maxnoe commented Jan 27, 2022

@FrancaCassol I think we also need a follow up PR changing the default configuration, right?

Are you doing that?

@FrancaCassol
Copy link
Collaborator

yes, I have it ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants