-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DL3+ notebooks #895
Add DL3+ notebooks #895
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 77 77
Lines 6170 6170
=======================================
Hits 5240 5240
Misses 930 930 Continue to review full report at Codecov.
|
After v0.9 we should try to make all notebooks work with the current version of lstchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there notebooks for things that are supposed to be done with the tools, e.g. create_dl3_events_file
and create_irfs
?
To just show the workflow of the Tools. |
9f5a4e3
to
4aa066d
Compare
@chaimain But the notebooks duplicate code from the tools. |
Yes. I do not understand, how I can explain the workflow of the Tools, without doing so in a jupyter notebook. Can you elaborate more on this? |
@chaimain You show how you run the tools and explain what they do shortly in prose? Have a look in the inputs/outputs? We really should not duplicate the code in notebooks that is supposed to be run via command line tools. People who really want to understand the code need to look at the code, we shouldn't repeat it in a notebook |
Ok. I understand it now. Thanks! |
@maxnoe should the |
as commented at the beginning of the discussion, after the new release we should update all notebooks to make them work with the current version of lstchain and some of them like these ones should not contain the information that is better explained elsewhere (as in gammapy notebooks) |
already discussed and modifications will be implemented in the future
Adding 5 notebooks:
The energy-dependent cuts procedures follows #709