Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of a source-dependent config file #937

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Conversation

SeiyaNozaki
Copy link
Collaborator

This PR is just an update of the source-dependent configuration file following the latest update of the standard one.
I also changed the default n_off_wobble to 1 from 3.

@rlopezcoto
Copy link
Contributor

tests are based on having three off positions as default, that is why they are not passing, maybe we could adapt them to make them pass for any number of selected off positions?

@SeiyaNozaki
Copy link
Collaborator Author

thank you @rlopezcoto ! Now it should work with any number of n_off_wobble

Copy link
Contributor

@rlopezcoto rlopezcoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good, thanks @SeiyaNozaki !

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #937 (470500c) into master (62951c5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
- Coverage   85.52%   85.50%   -0.02%     
==========================================
  Files          78       78              
  Lines        6459     6464       +5     
==========================================
+ Hits         5524     5527       +3     
- Misses        935      937       +2     
Impacted Files Coverage Δ
lstchain/io/tests/test_config.py 100.00% <100.00%> (ø)
lstchain/scripts/tests/test_lstchain_scripts.py 99.64% <100.00%> (+<0.01%) ⬆️
lstchain/reco/r0_to_dl1.py 93.08% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62951c5...470500c. Read the comment docs.

@moralejo moralejo merged commit f3d8125 into master Mar 9, 2022
@maxnoe maxnoe deleted the srcdep_config_update branch March 9, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants