-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine the post DL3 notebooks, to solve few minor issues #955
Conversation
…some more features
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Very good notebook but I still had a couple of comments. Some of them need to be solved before merging. It seems like your build is failing due to "lstchain_longterm_dl1_check" which is weird. |
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
==========================================
+ Coverage 85.46% 85.49% +0.03%
==========================================
Files 78 78
Lines 6461 6461
==========================================
+ Hits 5522 5524 +2
+ Misses 939 937 -2
Continue to review full report at Codecov.
|
Shouldn't the original notebooks also be removed? |
Ah Sorry, I thought I had done so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good. I didn't go over previously reviewed code again. I think you can merge.
The LC was not produced appropriately, by providing any custom energy range, as gammapy required the flux points edges to be the same as the "energy" axis (used for the events) provided while creating the SpectrumDataset.
So, to keep the process uniform, I combine the 3 notebooks, back into a single notebook, where the energy range for LC estimation depends on the energy edges of the
energy_axis
. Also,energy_axis
andenergy_fit_edges
have the same edges.Other changes are -
SafeMaskMaker
I request analyzers to review and check if there is a need for some more modification or information in this general example notebook.