Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamps in DL3 files, fixes #986 #987

Merged
merged 2 commits into from
May 26, 2022
Merged

Fix timestamps in DL3 files, fixes #986 #987

merged 2 commits into from
May 26, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented May 23, 2022

Timestamps were wrong by amount of UTC leap seconds before.

Timestamps were wrong by amount of UTC leap seconds before.
@maxnoe maxnoe requested a review from chaimain May 23, 2022 12:35
@maxnoe maxnoe changed the title Fix timestamps in DL3 files. Fix timestamps in DL3 files, fixes #986 May 23, 2022
lstchain/high_level/tests/test_hdus.py Outdated Show resolved Hide resolved
lstchain/high_level/hdu_table.py Show resolved Hide resolved
lstchain/high_level/hdu_table.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #987 (cb590ea) into master (fdf7423) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   85.69%   85.74%   +0.04%     
==========================================
  Files          78       78              
  Lines        6572     6592      +20     
==========================================
+ Hits         5632     5652      +20     
  Misses        940      940              
Impacted Files Coverage Δ
lstchain/high_level/hdu_table.py 93.71% <100.00%> (+0.12%) ⬆️
lstchain/high_level/tests/test_hdus.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf7423...cb590ea. Read the comment docs.

@moralejo moralejo merged commit dffc8bb into master May 26, 2022
@moralejo moralejo deleted the fix_dl3_times branch May 26, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants