Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying extractors per telescope, fixes #1660 #1661

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Mar 19, 2021

Use a TelescopeParameter for image_extractor_type and a dict[image_extractor_type] -> instanceof(ImageExtractor) for the actual extractors.

@maxnoe maxnoe requested a review from watsonjj as a code owner March 19, 2021 16:02
kosack
kosack previously approved these changes Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1661 (9027ef8) into master (83d1a5d) will increase coverage by 0.00%.
The diff coverage is 92.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1661   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files         186      186           
  Lines       13862    13887   +25     
=======================================
+ Hits        12536    12559   +23     
- Misses       1326     1328    +2     
Impacted Files Coverage Δ
ctapipe/image/reducer.py 92.00% <70.00%> (-3.56%) ⬇️
ctapipe/calib/camera/calibrator.py 94.94% <100.00%> (+0.26%) ⬆️
ctapipe/calib/camera/tests/test_calibrator.py 100.00% <100.00%> (ø)
ctapipe/tools/display_integrator.py 96.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d1a5d...9027ef8. Read the comment docs.

@maxnoe maxnoe merged commit 8258e30 into master Apr 15, 2021
@maxnoe maxnoe deleted the extractor_per_telescope branch April 15, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants