Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for numpy 2.0 #2580

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Add support for numpy 2.0 #2580

merged 3 commits into from
Sep 5, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 9, 2024

No description provided.

@maxnoe maxnoe marked this pull request as draft July 9, 2024 09:55
@maxnoe
Copy link
Member Author

maxnoe commented Jul 9, 2024

Core dependency tables does not yet support numpy 2.0, see PyTables/PyTables#1172

@maxnoe
Copy link
Member Author

maxnoe commented Sep 4, 2024

The remaining test failures are all due to the changed behavior of copy=False, which with numpy 2.0 now errors when the copy cannot be avoided.

This needs to be replaced with copy=None, astropy has a COPY_AS_NEEDED that is None if running under numpy 2.0 and False for earlier numpy versions, I'll add this here as well.

@maxnoe maxnoe changed the title Remove pin to numpy < 2 Add support for numpy 2.0 Sep 5, 2024
@maxnoe maxnoe marked this pull request as ready for review September 5, 2024 11:15
@kosack kosack merged commit 405e783 into main Sep 5, 2024
12 checks passed
@kosack kosack deleted the numpy2 branch September 5, 2024 12:47
@maxnoe maxnoe added this to the 0.22.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants