Fix changelog checks #2642
Merged
Fix changelog checks #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
maxnoe
reviewed
Nov 8, 2024
| fail: true | ||
| - name: Check for at least one changelog fragment | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-changelog-needed') }} | ||
| run: | |
There was a problem hiding this comment.
Couldn't this just be:
find docs/changes -type f | grep -P "${FRAGMENT_NAME_PREFIX}/\.(feature|bugfix|api|datamodel|optimization|maintenance)\.rst"
?
There was a problem hiding this comment.
automatically did in pure bash, but this is indeed much neater.
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
maxnoe
approved these changes
Nov 8, 2024
LukasBeiske
approved these changes
Nov 8, 2024
Tobychev
reviewed
Nov 8, 2024
| files: ${{ env.FRAGMENT_NAME }} | ||
| fail: true | ||
| - name: Check for at least one changelog fragment | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-changelog-needed') }} |
There was a problem hiding this comment.
Are you absolutely sure that no space after "!" works as you want? The evaluation rules for bash are very fickle and specific.
There was a problem hiding this comment.
yes. This PR has the "no-changelog-needed" label and passes the changelog check despite it has no changelog entry.
There was a problem hiding this comment.
This is not bash, it is githubs expression language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bash script instead of file-existence-action, as that action doesn't seem to have an option "check if at least one exists"
Tested manually with local run of github-actions.
Currently add "no-changelog-needed" label, but can remove and add changelog for automated test.
Not sure if this propagate to an actual changelog though.