-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctar1 fixes #199
Ctar1 fixes #199
Conversation
…ing dt correction
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 89.48% 89.42% -0.06%
==========================================
Files 20 21 +1
Lines 2245 2346 +101
==========================================
+ Hits 2009 2098 +89
- Misses 236 248 +12
☔ View full report in Codecov by Sentry. |
This PR is already pretty large and is enough to get analysis working of data taken with EVBv6 without corrections applied or with manually specifying which corrections have already been applied. Could you please review @FrancaCassol @moralejo or @SeiyaNozaki ? I'll open another PR for the missing module and the automatic detection of calibration steps already performed by EVB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look at seems ok to me, but better if sb else checks it too...
offset = self.data_stream.waveform_offset | ||
pixel_id_map = self.camera_config.pixel_id_map | ||
|
||
# FIXME: missing modules / pixels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will not work yet with data with missing modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not yet, see my comment above.
I'd like to separate that part into a second PR, with proper dummy test data and so on. This one will get pretty large if I want to include everything.
Changes to make it fully work with EVBv6 data, not yet ready, will update as more test data is taken
Missing: