Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform broken pixels check only in case of non-dvred pixels #207

Merged
merged 1 commit into from
Dec 5, 2023
+1 −1
Merged

Perform broken pixels check only in case of non-dvred pixels #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ctapipe_io_lst/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,7 @@ def fill_r0r1_camera_container(self, zfits_event):
# the code here works for both cases but not for the hypothetical
# case of broken pixels marked as broken (so camera config as 1855 pixels)
# and 1855 pixel_status entries but broken pixels not contained in `waveform`
if np.any(broken_pixels) and len(waveform) < n_pixels:
if not self.dvr_applied and np.any(broken_pixels) and len(waveform) < n_pixels:
raise NotImplementedError(
"Case of broken pixels not contained in waveform is not implemented."
"If you encounter this error, open an issue in ctapipe_io_lst noting"
Expand Down
Loading