Fix definition of evb preprocessing flags, apply calibration only when needed #209
Conversation
maxnoe
force-pushed
the
automatic_evb_corrections
branch
from
687f347
to
b6bc6fe
Compare
maxnoe
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 89.81% 90.67% +0.85%
==========================================
Files 21 22 +1
Lines 2415 2498 +83
==========================================
+ Hits 2169 2265 +96
+ Misses 246 233 -13 ☔ View full report in Codecov by Sentry. |
| As of 2024-01-26, there is a bug in EVB that the ttype_pattern and | ||
| tdp_action arrays are actually mixed up in the camera_configuration | ||
| object. |
There was a problem hiding this comment.
Can this be explained a bit more? The meaning of both items, and the nature (and consequences) of the problem.
There was a problem hiding this comment.
EVB just filled the real ttype_pattern into tdp_action and vice-versa. So the consequence is that if you want to know one, you actually have to look into the other field.
There was a problem hiding this comment.
Is that actually fixed now in the code anywhere? Or simply not yet used?
There was a problem hiding this comment.
I checked again and realized I had not updated the get_evb_preprocessings function below. This is now done and I added a test.
As far as I know, this bug is not yet fixed in EVB.
maxnoe
force-pushed
the
automatic_evb_corrections
branch
from
5589ff1
to
0167f45
Compare
maxnoe
force-pushed
the
automatic_evb_corrections
branch
from
0167f45
to
c82b0b7
Compare
No description provided.