Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test assert #220

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix test assert #220

merged 1 commit into from
May 7, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented May 7, 2024 •
edited
Loading

The assert was tautological...

@maxnoe maxnoe requested a review from morcuended May 7, 2024 15:29
@codecov Codecov
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (df019a7) to head (d55ae58).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files          22       22           
  Lines        2543     2543           
=======================================
  Hits         2315     2315           
  Misses        228      228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

morcuended
morcuended approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@morcuended morcuended left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, in the CI run before codecov failed for python 3.9 (complaining something about tokens, something similar happened in lstmcpipe)

src/ctapipe_io_lst/tests/test_lsteventsource.py Show resolved Hide resolved
@maxnoe maxnoe merged commit 62221dd into main May 7, 2024
8 checks passed
@maxnoe maxnoe deleted the fix_arbitrary_filename branch May 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morcuended morcuended morcuended approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxnoe @morcuended