Add module_id, hardware_pixel_id, module_pixel_index to camera geometry table #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 91.03% 91.29% +0.26%
==========================================
Files 22 25 +3
Lines 2542 2618 +76
==========================================
+ Hits 2314 2390 +76
Misses 228 228 ☔ View full report in Codecov by Sentry. |
* module_id * hardware_pixel_id * index in module * DRS4 chip info Also add functions to create such a mapping from CameraConfiguration object in data files.
morcuended
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Looks fine to me. Maybe a camera expert should also have a look.
LSTCam.camgeom.fits.gz is this file an updated version of the existing one?
moralejo
changed the title
moralejo
approved these changes
Jul 30, 2024
dkerszberg
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Looks good to me but maybe better if @SeiyaNozaki also has a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result: