Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit issue with CTA effective area perf and req #174

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Apr 7, 2022

No description provided.

@vuillaut vuillaut requested a review from mikael10j April 7, 2022 14:43
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #174 (5167a08) into master (eafbe37) will increase coverage by 0.19%.
The diff coverage is 32.23%.

❗ Current head 5167a08 differs from pull request most recent head 6027a86. Consider uploading reports for the commit 6027a86 to get more accurate results

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   63.15%   63.35%   +0.19%     
==========================================
  Files          21       21              
  Lines        2717     2726       +9     
==========================================
+ Hits         1716     1727      +11     
+ Misses       1001      999       -2     
Impacted Files Coverage Δ
ctaplot/gammaboard/reader.py 0.00% <0.00%> (ø)
ctaplot/gammaboard/gammaboard.py 11.92% <1.29%> (+0.01%) ⬆️
ctaplot/ana/ana.py 88.20% <84.61%> (-0.03%) ⬇️
ctaplot/__init__.py 100.00% <100.00%> (ø)
ctaplot/ana/tests/test_ana.py 100.00% <100.00%> (ø)
ctaplot/plots/plots.py 78.46% <100.00%> (ø)
ctaplot/plots/tests/test_plots.py 98.73% <100.00%> (+0.07%) ⬆️
ctaplot/plots/style.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbd6ee...6027a86. Read the comment docs.

@vuillaut vuillaut merged commit 1ebb254 into master Apr 7, 2022
@vuillaut vuillaut deleted the fix_effective_area branch April 7, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants