Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix particle id guessing when loading data #195

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fix particle id guessing when loading data #195

merged 2 commits into from
Jul 20, 2023

Conversation

mikael10j
Copy link
Collaborator

removes the casting to set of the array of mc_particle as set is not subscriptable

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Patch coverage: 31.61% and project coverage change: +0.12 🎉

Comparison is base (eafbe37) 63.15% compared to head (b0140f4) 63.27%.

❗ Current head b0140f4 differs from pull request most recent head 0c2467a. Consider uploading reports for the commit 0c2467a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   63.15%   63.27%   +0.12%     
==========================================
  Files          21       20       -1     
  Lines        2717     2715       -2     
==========================================
+ Hits         1716     1718       +2     
+ Misses       1001      997       -4     
Impacted Files Coverage Δ
ctaplot/gammaboard/reader.py 0.00% <0.00%> (ø)
ctaplot/plots/style.py 100.00% <ø> (ø)
ctaplot/gammaboard/gammaboard.py 11.86% <2.24%> (-0.05%) ⬇️
ctaplot/ana/ana.py 88.08% <86.66%> (-0.15%) ⬇️
ctaplot/ana/tests/test_ana.py 100.00% <100.00%> (ø)
ctaplot/plots/plots.py 78.46% <100.00%> (ø)
ctaplot/plots/tests/test_plots.py 98.73% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vuillaut vuillaut self-requested a review November 28, 2022 17:54
@vuillaut vuillaut merged commit f5d9751 into master Jul 20, 2023
@vuillaut vuillaut deleted the get_part_id branch July 20, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants