-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use seaborn-v0_8 as style, seaborn being deprecated #201
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 63.15% 63.20% +0.04%
==========================================
Files 21 21
Lines 2717 2734 +17
==========================================
+ Hits 1716 1728 +12
- Misses 1001 1006 +5
☔ View full report in Codecov by Sentry. |
notebook fails to render due to numpy removing these aliases a couple of versions ago |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
docs deployment problem might come from the new sphinx v7 being incompatible with rtd_theme (?). So maybe force sphinx < 7 |
Locally building worked with sphinx 7 and rtd theme, let's see |
the build on rtd still uses sphinx 7 🤔 |
@@ -8,6 +8,6 @@ scikit-learn | |||
jupyter | |||
ipywidgets | |||
recommonmark | |||
sphinx>=4.2<7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was just a comma missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn yes 😅
well it's fine now
No description provided.