Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use seaborn-v0_8 as style, seaborn being deprecated #201

Merged
merged 15 commits into from
Sep 19, 2023
Merged

Conversation

vuillaut
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 31.81% and project coverage change: +0.04% 🎉

Comparison is base (eafbe37) 63.15% compared to head (220df87) 63.20%.
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   63.15%   63.20%   +0.04%     
==========================================
  Files          21       21              
  Lines        2717     2734      +17     
==========================================
+ Hits         1716     1728      +12     
- Misses       1001     1006       +5     
Files Changed Coverage Δ
ctaplot/gammaboard/reader.py 0.00% <0.00%> (ø)
ctaplot/gammaboard/gammaboard.py 11.81% <2.94%> (-0.10%) ⬇️
ctaplot/ana/ana.py 88.20% <86.66%> (-0.03%) ⬇️
ctaplot/__init__.py 100.00% <100.00%> (ø)
ctaplot/ana/tests/test_ana.py 100.00% <100.00%> (ø)
ctaplot/plots/plots.py 78.49% <100.00%> (+0.02%) ⬆️
ctaplot/plots/style.py 100.00% <100.00%> (ø)
ctaplot/plots/tests/test_plots.py 98.73% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe mentioned this pull request Sep 19, 2023
@maxnoe
Copy link
Member

maxnoe commented Sep 19, 2023

examples/notebooks/roc_curves.ipynb
160:    "    reco_proba[p] = np.ones_like(mc_type, dtype=np.float)\n",

notebook fails to render due to numpy removing these aliases a couple of versions ago

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@morcuended
Copy link
Member

morcuended commented Sep 19, 2023

docs deployment problem might come from the new sphinx v7 being incompatible with rtd_theme (?). So maybe force sphinx < 7
EDIT: or use the new sphinx_rtd_theme version that apparently supports sphinx 7

@vuillaut vuillaut closed this Sep 19, 2023
@vuillaut vuillaut reopened this Sep 19, 2023
@vuillaut vuillaut closed this Sep 19, 2023
@vuillaut vuillaut reopened this Sep 19, 2023
@maxnoe
Copy link
Member

maxnoe commented Sep 19, 2023

Locally building worked with sphinx 7 and rtd theme, let's see

@vuillaut
Copy link
Member Author

the build on rtd still uses sphinx 7 🤔

@vuillaut vuillaut merged commit 86f9426 into master Sep 19, 2023
6 of 7 checks passed
@vuillaut vuillaut deleted the seaborn branch September 19, 2023 13:47
@@ -8,6 +8,6 @@ scikit-learn
jupyter
ipywidgets
recommonmark
sphinx>=4.2<7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was just a comma missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn yes 😅
well it's fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants