Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update magic mc treatment #104

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Update magic mc treatment #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ef1b19
Update version of ctapipe-io-magic.
aleberti Oct 7, 2022
e3bc50b
Update script for MAGIC data treatment: now MC have also unsuitable p…
aleberti Oct 7, 2022
7068545
Support mono MC data and SumT data (but warning about missing MaTaJu …
aleberti Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions magicctapipe/scripts/lst1_magic/magic_calib_to_dl1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,8 @@ def magic_calib_to_dl1(
f"\nIs SUM trigger: {is_sum_trigger}"
)

if is_simulation and not is_stereo_trigger:
logger.info("\nMono trigger MC data is not yet supported. Exiting...")
sys.exit()

if is_sum_trigger:
logger.info("\nSUM trigger data is not yet fully supported. Exiting...")
sys.exit()
logger.warning("\nSUM trigger data is supported, but MaTaJu cleaning is not implemented.")

if not is_simulation:

Expand Down Expand Up @@ -154,13 +149,6 @@ def magic_calib_to_dl1(
# Configure the MAGIC image cleaning
config_clean = config["MAGIC"]["magic_clean"]

if is_simulation and config_clean["find_hotpixels"]:
logger.warning(
"\nWARNING: Hot pixels do not exist in a simulation. "
"Setting the 'find_hotpixels' option to False..."
)
config_clean.update({"find_hotpixels": False})

logger.info("\nMAGIC image cleaning:")
for key, value in config_clean.items():
logger.info(f"\t{key}: {value}")
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
'astropy>=4.0.5,<5',
'lstchain~=0.9.6',
'ctapipe~=0.12.0',
'ctapipe_io_magic~=0.4.6',
'ctapipe_io_magic~=0.4.7',
'ctaplot~=0.5.5',
'eventio>=1.5.1,<2.0.0a0', # at least 1.1.1, but not 2
'gammapy~=0.19.0',
Expand Down