Fix the issue when creating an event list HDU #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculating their mean values
Elisa-Visentin
pushed a commit
that referenced
this pull request
Sep 12, 2024
Fix the issue when creating an event list HDU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry but I realized that the pull request #103 did not solve the problem of creating an event list HDU. The type of
combo_typeis indeed converted to int inget_stereo_events, but it is again converted to float inget_dl2_mean, where the mean ofcombo_typeis calculated and it automatically changes its type. With this pull request I added a line to reconvert it (and in additionmultiplicity) to int, and it finally fixed the problem.