Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the notebook to reconstruct a source flux #117

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

YoshikiOhtani
Copy link
Collaborator

With this pull request I updated the notebook check_sed_from_dl3.ipynb to reconstruct a source flux as follows:

  • Add the code to reconstruct the light curve at the end of the notebook.
  • Remove the support for the older version of gammapy, since it is best to use the new feature, especially WobbleRegionsFinder and using dynamic theta cuts.
  • Update the style to improve the readability and make it user-friendly.
  • Rename from "check_sed" to "check_flux" since I added the code to reconstruct the light curve.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@YoshikiOhtani YoshikiOhtani merged commit 7d6c7c8 into master Oct 25, 2022
@YoshikiOhtani YoshikiOhtani deleted the update-notebook branch October 25, 2022 14:43
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Update the notebook to reconstruct a source flux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant