-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update environment to fix pip installation and fix CI #134
Update environment to fix pip installation and fix CI #134
Conversation
- removed dependencies that already come with ctapipe - fixed jupyterlab to latest version compatible with this project
- removed dependencies already installed by ctapipe
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Next time you can simply create a branch in this repository and do the changes there, you have all the rights to write in this repo. This makes it easier for me (and others) to test, because I can simply change to the branch of the PR and test. |
In any case, it works nicely. I will merge it. |
When I created this PR I had no write access to this repository (we forgot to ask you for it) and I cannot persuade anybody to let me be a 'ghostwriter'. |
Ah sorry, then my fault! Now you have the write rights, so no need to persuade anyone :) |
The maintainers team should make sure that the master branch is actually protected by the CI pipeline otherwise the next PR will fail again. |
Update environment to fix pip installation and fix CI
ctapipe
jupyterlab
to latest version compatible withmagic-cta-pipe
pyflakes
errors which were preventing the CI to succeedblack