Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment to fix pip installation and fix CI #134

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

Elisa-Visentin
Copy link
Collaborator

@Elisa-Visentin Elisa-Visentin commented Feb 17, 2023

  • removed all dependencies already installed by ctapipe
  • fixed jupyterlab to latest version compatible with magic-cta-pipe
  • fixed pyflakes errors which were preventing the CI to succeed
  • formatted all code with black

- removed dependencies that already come with ctapipe
- fixed jupyterlab to latest version compatible with this project
- removed dependencies already installed by ctapipe
@Elisa-Visentin Elisa-Visentin marked this pull request as draft February 20, 2023 13:07
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Elisa-Visentin Elisa-Visentin changed the title Update environment to fix pip installation Update environment to fix pip installation and fix CI Feb 20, 2023
@Elisa-Visentin Elisa-Visentin marked this pull request as ready for review February 20, 2023 16:09
@aleberti
Copy link
Collaborator

aleberti commented Mar 2, 2023

Next time you can simply create a branch in this repository and do the changes there, you have all the rights to write in this repo. This makes it easier for me (and others) to test, because I can simply change to the branch of the PR and test.

@aleberti
Copy link
Collaborator

aleberti commented Mar 2, 2023

In any case, it works nicely. I will merge it.

@aleberti aleberti merged commit dbcb344 into cta-observatory:master Mar 2, 2023
@Elisa-Visentin
Copy link
Collaborator Author

Next time you can simply create a branch in this repository and do the changes there, you have all the rights to write in this repo. This makes it easier for me (and others) to test, because I can simply change to the branch of the PR and test.

When I created this PR I had no write access to this repository (we forgot to ask you for it) and I cannot persuade anybody to let me be a 'ghostwriter'.
Anyway thanks to @HealthyPear, too (for help and persuasion)

@aleberti
Copy link
Collaborator

aleberti commented Mar 2, 2023

Ah sorry, then my fault! Now you have the write rights, so no need to persuade anyone :)

@HealthyPear
Copy link
Member

In any case, it works nicely. I will merge it.

The maintainers team should make sure that the master branch is actually protected by the CI pipeline otherwise the next PR will fail again.

Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Update environment to fix pip installation and fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants