Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI badge according to latest practices. #169

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

aleberti
Copy link
Collaborator

@aleberti aleberti commented Nov 3, 2023

Following https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge. The badge was showing "failing" even if the CI was succesfull.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6baba4f) 76.13% compared to head (daab346) 76.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   76.13%   76.13%           
=======================================
  Files          21       21           
  Lines        2489     2489           
=======================================
  Hits         1895     1895           
  Misses        594      594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleberti aleberti added the maintenance Maintenance related label Nov 3, 2023
@aleberti aleberti merged commit 4afa0a1 into master Nov 3, 2023
6 checks passed
@aleberti aleberti deleted the fix_ci_badge branch November 3, 2023 13:57
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Update CI badge to have it working correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant