Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the repository #18

Merged
merged 22 commits into from
Feb 7, 2022
Merged

Reorganize the repository #18

merged 22 commits into from
Feb 7, 2022

Conversation

YoshikiOhtani
Copy link
Collaborator

Let me reorganize the structure of the repository

@YoshikiOhtani
Copy link
Collaborator Author

YoshikiOhtani commented Feb 1, 2022

So what I mainly did is:

  • renamed the directory, from "reco" to "image", and from "train" to "reco"
  • removed MAGIC_Badpixels.py because the function will be implemented in ctapipe_io_magic
  • renamed the class of MAGIC_Cleaning.py to the capital ones
  • Moved some modules in utils directory to image or reco directory

I have to also modify the scripts because the modules are moved to the different directory, which will be done tomorrow. Anyway any comments are welcome.

@aleberti
Copy link
Collaborator

aleberti commented Feb 7, 2022

I will add some commits to this branch, updating some of the scripts in the magic directory. In this way I will update them and also have two versions of the same scripts (one from this branch, one from the master) in order to cross-check the new bad pixels implementation in ctapipe-io-magic

@YoshikiOhtani
Copy link
Collaborator Author

Ah sorry I just rebased this branch - actually I deleted the commit to remove the script of the bad pixel calculation for the cross-check purpose. If you are fine, @aleberti, can I merge this to the master branch? Then you can also merge your development #5 to master, and can cross-check the bad pixels calculation in master branch?

@aleberti
Copy link
Collaborator

aleberti commented Feb 7, 2022

Ok, I don't see the reason to merge into master now, but you can do it. Anyway, #5 is not for comparing images between different MCP versions (as I need now), but images between MARS and MCP (same for hillas parameters). Once you merge into master, I will create another branch to commit the modifications I need.

@YoshikiOhtani
Copy link
Collaborator Author

OK thanks, the reason is that I just don't want to keep this branch so long time because it just reorganizes the structure, and am doing some development starting from this branch.

@YoshikiOhtani YoshikiOhtani merged commit 3a4b92d into master Feb 7, 2022
@YoshikiOhtani YoshikiOhtani deleted the reorganize branch February 7, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants