Handle loading LST DL1 file from lstchain v0.9

[gabemery]

No description provided.

[Elisa-Visentin]

Fine for me. Here you are now assuming LST-1 ID = 1, so you loose a bit the IDs generalization, but we can accept this and fix it in the future by importing the configuration file (BTW, real data now only have ID =1)

[aleberti]

Well, it can be fixed now I would say. We can just simply pass the dictionary of the mc tel ids (not all the config, unless we need something else from there to be passed to the function), so that even if there are more LSTs added in the future in the real data, the function is already usable.

[Elisa-Visentin]

But I wanted to spare him some extra work both on the coincidence script and on the tests. He has already offered to fix the SubArray!

[gabemery]

@aleberti This fix is meant to handle loading dl1 data from existing lstchain v0.9 files. So it will never be applied to dl1 data from LST2-4.

In case a dl1 file contains the data from multiple telescopes (not sure if this is the plan) and such a fix is still needed in the future, the tel_ids could probably be read from the dl1 file.

[aleberti]

Well, in any case the ID is changed later in the coincidence script. Also, we cannot even get the telescope ID from the broken subarray. So, not much to do anyway.

[aleberti]

There are no new comment since 2 weeks. @jsitarek green light from your side to merge? You have been assigned as 2nd reviewer.

[jsitarek]

I suggested one possible simplification, but since this is in the tests, it is also perfectly fine with me if you merge it as it is. Sorry for a big delay in checking this PR

[jsitarek]

thx @Elisa-Visentin
as soon as the checks finishes correctly I think we can merge

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.06%. Comparing base (8663b3d) to head (dc91ab9).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   76.87%   77.06%   +0.18%     
==========================================
  Files          21       21              
  Lines        2560     2581      +21     
==========================================
+ Hits         1968     1989      +21     
  Misses        592      592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.