Adding muon ring analysis #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much Gabriel for your contribution, and it looks fine to me. There are a few minor comments but anyway it should work without modifying them. It would be great if you could make another pull request once a new version of lstchain is released so that some modules are directly imported from it. |
|
Thanks @YoshikiOhtani , I did the modifications. And the plan is indeed to do another pull request as soon as the upgrade to a new release of lstchain is possible. |
|
OK thanks for the commit! Just in case let's ask in tomorrow's meeting if someone wants to comment, otherwise I can merge this to the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a muon ring analysis similar to what is used in lstchain for data. Works on LST and MAGIC MC. Main function should also work for real data (not tested) as in lstchain.
Contains temporary copied code from lstchain master.
example muon ring obtained :
