fixed the script so it works with the current version #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few of the variable names had to be updated, and some of the imports are now from different files
|
I updated the configuration file. Also, I use unsuitable pixels as calculated in ctapipe-io-magic. |
|
For the moment I merge the PR, and make another one cleaning up the scripts. I will just keep magic_calibrated_to_dl1, since it is a good reference to write out the events in the standard Dl1 format defined in ctapipe. |
aleberti
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few of the variable names had to be updated, and some of the imports are now from different files
@aleberti - I'm not sure if this script is still useful, if not we should simply remove it.
nevertheless I saw similar problems in other files. Also the config files need to be updated, but I was not sure which one is used by which script, hence I did not modify them in this PR