-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for processing MARS MC _Y_ files #45
Conversation
Hi @jsitarek, thanks for your modifications, in general it looks fine for me, as you already succeeded in processing MAGICSoft MCs with this changes. Still, I have some ideas to make it more automatically as I already commented, and so if you don't mind I would like to push a new commit with my modifications on this script, is it fine for you? |
Hi @YoshikiOhtani do you mean a new commit in this branch, or to make a separate PR from the main branch? |
Hi @jsitarek, I meant a commit to this branch, but if you prefer I can make a new PR after merging this branch to master. |
I think it is best if you commit to this branch (just wanted to make sure that this is what you actually meant). |
… but taken from ctapipe_io_magic set also magic_stereo to true when reading MCs, because ctapipe_io_magic reads only stereo MC events
Hi @YoshikiOhtani |
I finished cleaning up the code. Let me briefly summarize the changes here:
I tested the updated scripts to some of MAGIC data and it worked fine. It would be great if someone could check them and give me some comments. By the way it accidentally contains a bug fix commit which is not related to this discussion, but I see that the bug has been already fixed by Elli and so please ignore the commit. |
Since I would like to make another pull request about dead time calculations based on these changes, let me merge this to the master. I confirmed that the updated script works fine so I hope it doesn't make any problems. |
No description provided.