Add muon analysis on calibrated data #50
Conversation
…d the muon analysis function to also work for this case.
There was a problem hiding this comment.
Thanks @gabemery
I left a few comments, but they are rather minor.
More tricky might be the quality cuts, we use some more in MARS, and here it is only the ring completeness.
One question, what kind of events were giving you TypeError?
| @@ -64,8 +64,8 @@ MAGIC: | |||
|
|
|||
| muon_ring: | |||
| thr_low: 25 | |||
| tailcut: [8, 4] | |||
There was a problem hiding this comment.
was the change of the thresholds intended? 12,8 looks quite large, did it come from your optimization?
There was a problem hiding this comment.
It is not optimised, but it followed a comment (by Abelardo?) that if we take only very bright pixels the biases from NSB should be reduced even if the charge extractor is not optimal.
|
|
||
| """ | ||
|
|
||
| event_source = MAGICEventSource(input_url=input_file) |
There was a problem hiding this comment.
I think it should work fine if you change to general EventSource, when the file is a MAGIC Y file it will automatically select MAGICEventSource, and this will make it easier to run the same script also on LST
| telescope_name=tel_name, | ||
| image=image, | ||
| subarray=subarray, | ||
| r1_dl1_calibrator_for_muon_rings= |
There was a problem hiding this comment.
I think putting here directly None except of a separate variable set to None would be more clear
|
I applied the proposed changes. |
Modified the analysis function to work in this case and added a dedicated script.
Related to #19