Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the definition of the DL2 parameter uncertainty #71

Merged
merged 16 commits into from
Jun 14, 2022

Conversation

YoshikiOhtani
Copy link
Collaborator

@YoshikiOhtani YoshikiOhtani commented May 31, 2022

It is still a draft pull request related to the issue #69.

@YoshikiOhtani YoshikiOhtani marked this pull request as draft May 31, 2022 15:09
@YoshikiOhtani YoshikiOhtani marked this pull request as ready for review June 6, 2022 14:21
@YoshikiOhtani
Copy link
Collaborator Author

YoshikiOhtani commented Jun 6, 2022

So now I opened this pull request for reviews. In short summary, it includes:

  • the calculation of the reco energy uncertainty with log10(Ereco) instead of Ereco
  • the calculation of the gammaness uncertainty with binomial variance
  • an option to select the type of weights, "none" None, "uncert" and "intensity" (default: "uncert" None)

I assigned @jsitarek for a reviewer and so it would be appreciated if you could give me comments or approval if it is fine. Thanks!

@YoshikiOhtani YoshikiOhtani linked an issue Jun 6, 2022 that may be closed by this pull request
@YoshikiOhtani
Copy link
Collaborator Author

Sorry for pushing again some commits, but I have also updated the scripts of creating the IRFs and DL3 files so that one can select the type of DL2 weight. Also, I changed the default weight to None (means weight = 1) for a safe side.

Copy link
Collaborator

@jsitarek jsitarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YoshikiOhtani
Thanks for the change.
I suggested to rename one of the variables
And I also have a side comment concerning the lat/lon averaging.Other than this it is fine with it.

magicctapipe/reco/estimators.py Outdated Show resolved Hide resolved
magicctapipe/reco/estimators.py Outdated Show resolved Hide resolved
magicctapipe/reco/estimators.py Outdated Show resolved Hide resolved
magicctapipe/reco/estimators.py Outdated Show resolved Hide resolved
magicctapipe/scripts/lst1_magic/config.yaml Outdated Show resolved Hide resolved
magicctapipe/utils/functions.py Outdated Show resolved Hide resolved
magicctapipe/utils/functions.py Outdated Show resolved Hide resolved
@YoshikiOhtani
Copy link
Collaborator Author

Hi @jsitarek, thank you very much for your reviews, I pushed the change of the variable names and also the transformation of the mean Alt/Az to the RA/Dec coordinate instead of computing the mean RA/Dec coordinate. Would be great if you could give an approval in case the changes are fine for you. Thanks!

@YoshikiOhtani YoshikiOhtani merged commit ffdb37d into master Jun 14, 2022
@YoshikiOhtani
Copy link
Collaborator Author

I'm sorry but I mistakenly/accidentally merged this branch to the master... please let me know if you find some problems...!

@YoshikiOhtani YoshikiOhtani deleted the dl2-reco-err branch June 14, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Averaging telescope-wise parameters
2 participants