-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the definition of the DL2 parameter uncertainty #71
Conversation
So now I opened this pull request for reviews. In short summary, it includes:
I assigned @jsitarek for a reviewer and so it would be appreciated if you could give me comments or approval if it is fine. Thanks! |
…-pipe into dl2-reco-err Conflicts: magicctapipe/scripts/lst1_magic/lst1_magic_dl2_to_dl3.py
Sorry for pushing again some commits, but I have also updated the scripts of creating the IRFs and DL3 files so that one can select the type of DL2 weight. Also, I changed the default weight to None (means weight = 1) for a safe side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @YoshikiOhtani
Thanks for the change.
I suggested to rename one of the variables
And I also have a side comment concerning the lat/lon averaging.Other than this it is fine with it.
Hi @jsitarek, thank you very much for your reviews, I pushed the change of the variable names and also the transformation of the mean Alt/Az to the RA/Dec coordinate instead of computing the mean RA/Dec coordinate. Would be great if you could give an approval in case the changes are fine for you. Thanks! |
I'm sorry but I mistakenly/accidentally merged this branch to the master... please let me know if you find some problems...! |
It is still a draft pull request related to the issue #69.