Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stereo reconstruction #77

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Refactor stereo reconstruction #77

merged 4 commits into from
Jul 25, 2022

Conversation

YoshikiOhtani
Copy link
Collaborator

This pull request includes some minor refactoring of the code of the stereo parameters reconstruction. Here is a brief summary of the changes:

  • changed the option name of the function stereo_reconstruction from magic_only to magic_only_analysis (but the argument name --magic-only used when running the script does not change).
  • cleaned up the code of checking the angular distance of the pointing directions
  • modified the logger information display

I checked that the outputs do not change before and after the refactoring and so it would be safe to merge now, but again I keep it here a few days so any comments or requests are very welcome.

@aleberti
Copy link
Collaborator

Also here changes look good, no particular comment from my side

@YoshikiOhtani
Copy link
Collaborator Author

I just pushed a commit about the change of an output file name when using the --magic-only argument to clarify from name that the data are processed by only MAGICs.

@YoshikiOhtani
Copy link
Collaborator Author

@aleberti I also modified the stereo reco script by following suggestions by flake8 (max-line-length = 90), and run isort and black. It would be much appreciated if you could check it and merge to the master if it looks OK to you. Thanks!

@aleberti aleberti merged commit 6ffe868 into master Jul 25, 2022
@aleberti aleberti deleted the refactor-stereo branch July 25, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants