Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes some minor refactoring of the code of the stereo parameters reconstruction. Here is a brief summary of the changes:
stereo_reconstruction
frommagic_only
tomagic_only_analysis
(but the argument name--magic-only
used when running the script does not change).I checked that the outputs do not change before and after the refactoring and so it would be safe to merge now, but again I keep it here a few days so any comments or requests are very welcome.