Gain computation with SPE fit and Photo-statistic methods

[guillaumegrolleron]

There are 2 modules in the NectarGain package :

• PhotoStat : for gain computation (high and low gain) from a pedestal run, a flat field run and a SPE fit result
• SPEfit : for gain computation with SPE fit (only high gain).

Gain can be computed on ~1400V data, or nominal runs using results from 1400V fit (there are 2 method to perform the combined fit)

This package is based on the container module, input data used in SPEfit and PhotStat have to be container.

Note : This PR follows the PR #37

[jlenain]

Running a couple of tests with the different algorithms. So far, gain_SPEfit_computation.py works perfectly (technically speaking, I am not assessing here the scientific quality of the results). Testing gain_PhotoStat_computation.py and gain_SPEfit_combined_computation.py...

Everything working fine, with photostatistics method or SPE fits for single runs or combined fits.

To me, we're good to merge.

[dkerszberg]

Thank you @jlenain
I just left one minor comment, @guillaumegrolleron can you check it?
@vmarandon if all good for you can you "approve" the PR?

[kosack]

Does this have any connection to the spefit library used by other cameras in the ASWG repository?
https://gitlab.cta-observatory.org/cta-consortium/aswg/tools/spefit

[jlenain]

Does this have any connection to the spefit library used by other cameras in the ASWG repository? https://gitlab.cta-observatory.org/cta-consortium/aswg/tools/spefit

Thanks, @kosack . First, I think nobody here had any idea of the existence of this spefit library, so thanks a lot for pointing it out.

Looking quickly at the description of spefit though, there seems to be the case of the double gaussian fit method, as exposed in https://ui.adsabs.harvard.edu/abs/2019SPIE11119E..1WC/abstract, which is covered here but not there.

[kosack]

Thanks, yeah, I was just wondering if every camera is doing this separately or if there is some coordination? I would guess the methods should be the same for everyone. I imagine there is little inter-telescope coordination in CTA though!

[jlenain]

Ready to be merged, in my opinion!

[dkerszberg]

Also fine for me. @vmarandon had one final comment for @guillaumegrolleron can you have a look?

[jlenain]

Also fine for me. @vmarandon had one final comment for @guillaumegrolleron can you have a look?

@guillaumegrolleron is on it!

[jlenain]

Thanks a lot for the hard work, @guillaumegrolleron ! I am merging this PR now.