Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all ctapipe charge extractors #50

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Mar 29, 2023

This PR enables all possible charge extractors currently implemented in ctapipe.

@jlenain jlenain self-assigned this Mar 29, 2023
@jlenain jlenain added the enhancement New feature or request label Mar 29, 2023
@jlenain
Copy link
Collaborator Author

jlenain commented Mar 29, 2023

@guillaumegrolleron , @tibaldo , here is a PR related to our discussion this afternoon on different charge extractors to be enabled in @guillaumegrolleron 's script, especially for flat-field and pedestal runs.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c5200fc) 0.53% compared to head (7a01121) 0.53%.

❗ Current head 7a01121 differs from pull request most recent head 1025cf6. Consider uploading reports for the commit 1025cf6 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #50   +/-   ##
======================================
  Coverage    0.53%   0.53%           
======================================
  Files          23      23           
  Lines        2427    2427           
======================================
  Hits           13      13           
  Misses       2414    2414           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guillaumegrolleron
Copy link
Contributor

Indeed this modification should solve the issue, but I performed some tests and there is an error with numba for the charge extraction with the GlobalPeakWindowSum. I don't have solution yet but I will investigate before merging

  "BaselineSubtractedNeighborPeakWindowSum" extractor (bug unfixed)
-bugfix when using extractor on waveforms 3D (ctapipe written for 2D)
@jlenain jlenain merged commit 8494572 into cta-observatory:master Mar 30, 2023
@jlenain jlenain deleted the extractor branch March 30, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants