-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM: Adding protections for runs with 21 masked pixels (due to shutter) #63
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
=========================================
+ Coverage 3.08% 3.09% +0.01%
=========================================
Files 36 36
Lines 3571 3553 -18
=========================================
Hits 110 110
+ Misses 3461 3443 -18
☔ View full report in Codecov by Sentry. |
Hi @hashkar ! |
@hashkar , what is the status of this PR ? |
Hi @jlenain, can we close this pull request. I will do another one that contains all the fixes discussed here. Since it has been a while since I made changes I have many conflicts that i need to solve. I will solve them in another branch and make a new pull request |
Hi @hashkar ! |
Followed up in #80 |
fixing the 21 pixels issues for old runs: addin a check first.