Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: Adding protections for runs with 21 masked pixels (due to shutter) #63

Closed
wants to merge 11 commits into from

Conversation

hashkar
Copy link
Collaborator

@hashkar hashkar commented Jun 13, 2023

fixing the 21 pixels issues for old runs: addin a check first.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (0c65774) 3.08% compared to head (17b5789) 3.09%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #63      +/-   ##
=========================================
+ Coverage    3.08%   3.09%   +0.01%     
=========================================
  Files          36      36              
  Lines        3571    3553      -18     
=========================================
  Hits          110     110              
+ Misses       3461    3443      -18     
Files Changed Coverage Δ
src/nectarchain/dqm/camera_monitoring.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/charge_integration.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/dqm_summary_processor.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/mean_camera_display.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/mean_waveforms.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/start_calib.py 0.00% <0.00%> (ø)
src/nectarchain/dqm/trigger_statistics.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/nectarchain/dqm/charge_integration.py Outdated Show resolved Hide resolved
src/nectarchain/dqm/mean_camera_display.py Outdated Show resolved Hide resolved
@jlenain jlenain changed the title Adding layers of protection DQM: Adding protections for runs with 21 masked pixels (due to front window) Jun 14, 2023
@jlenain jlenain changed the title DQM: Adding protections for runs with 21 masked pixels (due to front window) DQM: Adding protections for runs with 21 masked pixels (due to shutter) Jun 14, 2023
@jlenain
Copy link
Collaborator

jlenain commented Jun 14, 2023

Hi @hashkar !
Did you try your changes on your side ? For run 2943, I get strange camera displays, possibly the mask on the 21 pixels is not properly handled:
PlotsNectarCAM_Run2943_Camera_Mean_HighGain
but:
PlotsNectarCAM_Run2943_ChargeInt_Mean_HighGain_All

jlenain added a commit to jlenain/nectarchain that referenced this pull request Jul 12, 2023
@jlenain
Copy link
Collaborator

jlenain commented Oct 20, 2023

@hashkar , what is the status of this PR ?

@hashkar
Copy link
Collaborator Author

hashkar commented Oct 20, 2023

Hi @jlenain, can we close this pull request. I will do another one that contains all the fixes discussed here. Since it has been a while since I made changes I have many conflicts that i need to solve. I will solve them in another branch and make a new pull request

@jlenain
Copy link
Collaborator

jlenain commented Oct 20, 2023

Hi @hashkar !
OK, I will close it, then.

@jlenain jlenain closed this Oct 20, 2023
@jlenain
Copy link
Collaborator

jlenain commented Dec 11, 2023

Followed up in #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants