Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calibration benchmarking settings #100

Conversation

HealthyPear
Copy link
Member

Description

There was a typo in the JSON configuration file for the generation of 2nd-pass reconstructed images produced with the TwoPassWindowSum image extractor.

This typo has been found in the image cleaning settings, which define the cleaning thresholds for the preliminary image cleaning in-between the 2 passes and it mistakenly discarded pixels by applying a +10 photoelectrons difference,

"TwoPassWindowSum": {
        "core_threshold" : [
          ["type", "*", 6.0],
          ["type", "LST_LST_LSTCam", 16.0],       -----> ["type", "LST_LST_LSTCam", 6.0],
          ["type", "MST_MST_NectarCam", 18.0]     -----> ["type", "MST_MST_NectarCam", 8.0]
        ],

Consequences

The optimized cleaning thresholds for the reference analysis (#24) will change as follows,

LSTCam : (7.24, 3.62)      ---> (6.61, 3.30)
NectarCam : (6.92, 3.46)   ---> (5.75, 2.88)

This will

  • update the information stored here regarding exclusively the 2nd pass,
  • have (hopefully positive) consequences on the results stored here.

@HealthyPear HealthyPear added wrong behaviour The code works but produces clearly wrong results fix A PR that fixes a bug or a wrong behaviour. benchmarks labels Feb 4, 2021
@HealthyPear HealthyPear added this to the v0.4.0 milestone Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #100 (f7638a6) into master (5b2a815) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   36.81%   36.81%           
=======================================
  Files          18       18           
  Lines        1798     1798           
=======================================
  Hits          662      662           
  Misses       1136     1136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2a815...1ffaf4e. Read the comment docs.

@HealthyPear HealthyPear merged commit 23c3840 into cta-observatory:master Feb 4, 2021
@HealthyPear HealthyPear deleted the fix-calibration-benchmark-settings branch February 4, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks fix A PR that fixes a bug or a wrong behaviour. wrong behaviour The code works but produces clearly wrong results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants