Fix calibration benchmarking settings #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a typo in the JSON configuration file for the generation of 2nd-pass reconstructed images produced with the TwoPassWindowSum image extractor.
This typo has been found in the image cleaning settings, which define the cleaning thresholds for the preliminary image cleaning in-between the 2 passes and it mistakenly discarded pixels by applying a +10 photoelectrons difference,
Consequences
The optimized cleaning thresholds for the reference analysis (#24) will change as follows,
This will