Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classifier integration test #120

Merged

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Mar 29, 2021

Requirements

Description

This PR fixes an error in the pipeline's testing workflow for which the testing function for the classifier(s) was actually using the energy regressor configuration file, thus not even using protons.

Caveat

Once this fix has been added the same integration test found an error in the execution of the script to build the models, so right now this PR cannot be merged until that error is fixed in a different PR (but it can be pre-reviewed).

@HealthyPear HealthyPear added fix A PR that fixes a bug or a wrong behaviour. maintenance labels Mar 29, 2021
@HealthyPear HealthyPear requested a review from kosack March 29, 2021 14:24
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #120 (ac3c4a4) into master (4c7a7fe) will increase coverage by 2.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   47.61%   49.97%   +2.35%     
==========================================
  Files          22       22              
  Lines        1995     1995              
==========================================
+ Hits          950      997      +47     
+ Misses       1045      998      -47     
Impacted Files Coverage Δ
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)
protopipe/scripts/build_model.py 86.61% <0.00%> (+25.98%) ⬆️
protopipe/mva/train_model.py 88.23% <0.00%> (+27.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7a7fe...ac3c4a4. Read the comment docs.

@HealthyPear HealthyPear merged commit b58e7ec into cta-observatory:master Mar 30, 2021
@HealthyPear HealthyPear deleted the fix-classifier_integration_test branch March 30, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A PR that fixes a bug or a wrong behaviour. maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants