Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concentration #133

Merged

Conversation

HealthyPear
Copy link
Member

In this PR concentration is added to the output of the EventPreparer class, so it is written out to TRAINING and DL2 formats.

It is only computed for the extended image (aka with all clusters)

ctapipe outputs concentration in 3 different definitions, none of which seem to coincide with the one used by CTAMARS, but we can use

concentration_pixel = image.max() / h.intensity

as a good approximation

@HealthyPear HealthyPear added enhancement New feature or request input / output new features or issues regarding input and output formats labels May 10, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone May 10, 2021
@HealthyPear HealthyPear linked an issue May 10, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #133 (f88d9ad) into master (9149e12) will increase coverage by 0.16%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   60.30%   60.46%   +0.16%     
==========================================
  Files          23       23              
  Lines        2091     2102      +11     
==========================================
+ Hits         1261     1271      +10     
- Misses        830      831       +1     
Impacted Files Coverage Δ
protopipe/scripts/write_dl2.py 82.45% <ø> (ø)
protopipe/pipeline/event_preparer.py 69.88% <88.88%> (+0.53%) ⬆️
protopipe/scripts/data_training.py 94.94% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9149e12...f88d9ad. Read the comment docs.

@HealthyPear HealthyPear merged commit ff7ea05 into cta-observatory:master May 11, 2021
@HealthyPear HealthyPear deleted the feature-add_concentration branch May 11, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request input / output new features or issues regarding input and output formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add concentration
2 participants