Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to choose which cleaning to use to get training data #135

Conversation

HealthyPear
Copy link
Member

The previous situation was one in which both cleanings were computed and recorded

  • biggest (meaning biggest cluster)
  • extended (meaning all clusters)

but the one used for image quality and shower geometry was always the one using the biggest cluster.

In accordance with #117, now it will be possible to choose between the 2 from analysis.yaml (under ImageSelection/source), and the default option is set to be "extended".

@HealthyPear HealthyPear added the enhancement New feature or request label May 10, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #135 (6fa1a9b) into master (b1e0a9d) will decrease coverage by 0.16%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   60.36%   60.20%   -0.17%     
==========================================
  Files          23       23              
  Lines        2122     2141      +19     
==========================================
+ Hits         1281     1289       +8     
- Misses        841      852      +11     
Impacted Files Coverage Δ
protopipe/pipeline/event_preparer.py 68.05% <60.00%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e0a9d...6fa1a9b. Read the comment docs.

@HealthyPear HealthyPear requested a review from kosack May 10, 2021 17:00
@HealthyPear HealthyPear merged commit c542797 into cta-observatory:master May 11, 2021
@HealthyPear HealthyPear deleted the feature-choose_image_quality_source branch May 11, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants