-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for DL2-to-DL3 step #137
Merged
HealthyPear
merged 15 commits into
cta-observatory:master
from
HealthyPear:maintenance-integration_test_getDL3
May 14, 2021
Merged
Add integration test for DL2-to-DL3 step #137
HealthyPear
merged 15 commits into
cta-observatory:master
from
HealthyPear:maintenance-integration_test_getDL3
May 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 60.35% 65.59% +5.24%
==========================================
Files 23 23
Lines 2101 2142 +41
==========================================
+ Hits 1268 1405 +137
+ Misses 833 737 -96
Continue to review full report at Codecov.
|
14 tasks
kosack
previously approved these changes
May 12, 2021
14 tasks
kosack
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the test for the last step of the pipeline.
I had to modify (actually slightly improve) the CLI of the script in order to overwrite some of the input settings coming from the configuration file.
I also added some development code from pyirf to allow the writing of empty tables of DL3 information in case no DL2 events are selected from the analysis (it happens with the prod3b CTAN test analysis).
The integration test checks that the script doesn't crash (for any reason) and that the output file has the expected number of HDUs from the current script and that each HDU has some data in it.