Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandas to pip installation #138

Merged

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented May 12, 2021

If installing only using pip it now required by both protopipe-TRAINING and protopipe-DL2 that pandas is installed together with ctapipe and pyirf

TODO:

  • test pure pip installation in the CI and not only the one based on the conda environment file

@HealthyPear HealthyPear added bug Something isn't working dependency stuff related to the dependencies of the package maintenance labels May 12, 2021
@HealthyPear HealthyPear marked this pull request as draft May 12, 2021 12:09
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #138 (6e965e1) into master (f3ccc76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   60.35%   60.35%           
=======================================
  Files          23       23           
  Lines        2101     2101           
=======================================
  Hits         1268     1268           
  Misses        833      833           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ccc76...6e965e1. Read the comment docs.

@HealthyPear HealthyPear requested a review from kosack May 12, 2021 12:46
@HealthyPear HealthyPear marked this pull request as ready for review May 12, 2021 12:46
@HealthyPear HealthyPear merged commit e7825c0 into cta-observatory:master May 14, 2021
@HealthyPear HealthyPear deleted the bug-add_pandas_to_requirements branch May 14, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependency stuff related to the dependencies of the package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants